Ticket #6439 (closed defect: fixed)

Bug contains 1 commit(s) | SVN Diffs for #6439

 

Opened 4 months ago

Last modified 2 months ago

incorrect preprocessor command

Reported by: jonathan@... Assigned to: eric
Priority: major Milestone: 4.1.1
Component: layout Version: Current
Keywords: Cc:
Load: Xref:
Java Version: Operating System:
Project (C/J): ICU4C Weeks:
Review: michaelow

Description

(reported to me by George N. White III)

In layoutex/ParagraphLayout.cpp, there is an #elif with no expression; I believe this should be #else. gcc 4.4 reports this as an error.

The following patch (based on 3.8.1, but the error is still present in trunk) corrects the problem:

$ diff -C3 Build/source/libs/icu-xetex/layoutex/ParagraphLayout.cpp.orig
Build/source/libs/icu-xetex/layoutex/ParagraphLayout.cpp
*** Build/source/libs/icu-xetex/layoutex/ParagraphLayout.cpp.orig	2008-03-20 09:51:52.000000000 -0300
--- Build/source/libs/icu-xetex/layoutex/ParagraphLayout.cpp	2008-07-13 07:17:52.000000000 -0300
***************
*** 854,860 ****

     return nullLanguageCode;
 }
! #elif

 // TODO - dummy implementation for right now...
 le_int32 ParagraphLayout::getLanguageCode(const Locale *locale)
--- 854,860 ----

     return nullLanguageCode;
 }
! #else

 // TODO - dummy implementation for right now...
 le_int32 ParagraphLayout::getLanguageCode(const Locale *locale)

Attachments

Change History

07/16/08 11:54:42 changed by yoshito

  • owner changed from somebody to eric.
  • weeks changed.
  • xref changed.
  • revw changed.

07/21/08 09:13:21 changed by hchapman

  • priority changed from assess to major.
  • milestone changed from UNSCH to 4.1.1.

07/25/08 12:52:56 changed by eric

  • status changed from new to assigned.
  • revw set to michaelow.

09/17/08 10:08:55 changed by michaelow

  • status changed from assigned to closed.
  • resolution set to fixed.

Add/Change #6439 (incorrect preprocessor command)




Anti spam check: