Ticket #6376 (new enhancement)

Bug contains 2 commit(s) | SVN Diffs for #6376

 

Opened 2 months ago

Last modified 3 weeks ago

Serialization Test Improvements

Reported by: eric Assigned to: krajwade
Priority: minor Milestone: 4.2
Component: unknown Version: Current
Keywords: Cc:
Load: ibm:100 Xref:
Java Version: Operating System:
Project (C/J): ICU4J Weeks: .2
Review: eric

Description

We should check private serializable classes for serialVersionUID by moving the check for serialVersionUID in CoverageTest.CoverageTarget.execute() to before the test for a null inputStream.

We should also ignore interfaces. This has to happen in three places:

1) in CoverageTest.visit(), change "if (Modifier.isPublic(m))" to "if (Modifier.isPublic(m) && !Modifier.isInterface(m))"

2) in SerializationChecker.visit() the check for serialVersionUID should not be done if Modifier.isInterface(m) returns true.

3) in SerializagtionChecker.visit() the check for a missing handler should also not be done if Modifier.inInterface(m) returns true.

Attachments

Change History

07/10/08 14:52:55 changed by yoshito

  • load set to ibm:100.
  • priority changed from major to minor.

07/22/08 10:23:47 changed by hchapman

  • owner changed from eric to krajwade.

08/05/08 12:28:56 changed by krajwade

  • revw set to eric.

Add/Change #6376 (Serialization Test Improvements)




Anti spam check: