Ticket #4521 (closed enhancement: fixed)

Bug contains 19 commit(s) | SVN Diffs for #4521

 

Opened 5 years ago

Last modified 1 week ago

Use abstract text access APIs in regular expressions

Reported by: weiv(at)jtcsv.com Assigned to: mishonok
Priority: major Milestone: 4.3.5
Component: regexp Version: 3.2
Keywords: Cc: deborah, pedberg, andy
Load: Apple:90 Google:10 Xref: 3944, 7406
Java Version: Operating System: all
Project (C/J): ICU4C Weeks: 9
Review: andy

Description (Last modified by grhoten)

Based on the work in 3944, adapt regular expression engine to using abstact text access APIs.

Attachments

Change History

12/31/69 17:45:11 changed by auditor

  • Wed Aug 3 17:48:55 2005 andy changed notes2: weeks: "" to "3.0",
  • Fri Mar 31 13:19:50 2006 ram changed notes2: target: "3.6" to "3.8",
  • Mon Oct 9 18:39:51 2006 grhoten changed notes2: priority: "committed" to "high", summmary: "" to "RFE: Use abstract text access APIs in regular expressions",
  • Tue Oct 17 22:47:25 2006 andy changed notes2: target: "3.8" to "3.8 Candidate",
  • Mon Nov 13 23:21:43 2006 srl changed notes2: priority: "high" to "medium", target: "3.8 Candidate" to "3.8",

12/05/06 17:53:35 changed by andy

  • priority changed from minor to major.
  • status changed from new to assigned.
  • weeks changed from 3.0 to 9.
  • java changed.
  • revw changed.

12/06/06 13:19:50 changed by deborah

  • cc set to goldsmit@apple.com.

03/23/07 11:47:23 changed by andy

  • load set to IBM:50 Apple:50 Google:10.
  • milestone changed from 3.8 to 4.0.

09/28/07 13:06:06 changed by andy

  • summary changed from RFE: Use abstract text access APIs in regular expressions to Use abstract text access APIs in regular expressions.

01/06/08 01:44:36 changed by grhoten

  • keywords deleted.
  • load changed from IBM:50 Apple:50 Google:10 to IBM:10 Apple:50 Google:10.
  • description changed.

01/06/08 01:46:14 changed by grhoten

  • load changed from IBM:10 Apple:50 Google:10 to Apple:50 Google:10.

03/21/08 10:33:05 changed by andy

  • milestone changed from 4.0 to UNSCH.

07/09/08 15:22:07 changed by yoshito

  • priority changed from major to assess.

07/15/08 15:30:12 changed by andy

  • owner changed from andy to pedberg.
  • priority changed from assess to major.
  • status changed from assigned to new.

11/06/09 10:27:58 changed by pedberg

  • milestone changed from UNSCH to 4.4.

01/17/10 20:39:35 changed by pedberg

  • milestone changed from 4.4 to 4.6.

New API, move to 4.6. Rolling this into Apple ICU sources currently, then will roll into open source.

01/25/10 20:13:31 changed by pedberg

  • cc changed from goldsmit@apple.com to deborah, pedberg, andy.
  • load changed from Apple:50 Google:10 to Apple:90 Google:10.
  • project changed from ICU4C,ICU4J and ICU4JNI to ICU4C.
  • owner changed from pedberg to mishonok.

02/02/10 15:51:11 changed by mishonok

OK, commited to branch mishonok/regex-2009/. Next I'llmerge onto trunk:

svn commit -m "ticket:4521: UText-based regex implementation" Sending source/common/unicode/utext.h Sending source/common/utext.cpp Sending source/i18n/Makefile.in Sending source/i18n/i18n.vcproj Sending source/i18n/regexcmp.cpp Sending source/i18n/regexcmp.h Sending source/i18n/regeximp.h Sending source/i18n/regexst.cpp Sending source/i18n/regexst.h Adding source/i18n/regextxt.cpp Adding source/i18n/regextxt.h Sending source/i18n/rematch.cpp Sending source/i18n/repattrn.cpp Sending source/i18n/unicode/regex.h Sending source/i18n/unicode/uregex.h Sending source/i18n/uregex.cpp Sending source/test/cintltst/reapits.c Sending source/test/intltest/regextst.cpp Sending source/test/intltest/regextst.h Sending source/test/intltest/utxttest.cpp Sending source/test/intltest/utxttest.h Transmitting file data ..................... Committed revision 27480.

02/02/10 19:48:25 changed by mishonok

Committed to trunk: Committed revision 27482.

missed a file: Sending source/test/intltest/regextst.h Committed revision 27484.

02/02/10 19:50:32 changed by mishonok

  • status changed from new to assigned.
  • revw set to andy.
  • milestone changed from 4.6 to 4.3.5.

02/02/10 21:13:52 changed by pedberg

  • xref changed from 3944 to 3944, 7406.

Added as "@internal 4.4" for ICU 4.4. Filed #7406 to move these to "@draft 4.4" for ICU 4.6.

02/24/10 23:02:05 changed by pedberg

OK, I think this is ready. A lot of the diffs are work on a branch, temporary fixes, etc. The real fixes are in the following diffs:

•1. initial merge from branch (uses 2 fExtra fields to hold 64-bit indices etc; this is changed in •4 below so fExtra fields are 64 bits, and we go back to using a single field for indices): r27482 r27484.
•2. disambiguate method signature: r27522
•3. fix dangling pointer: r27541
•4. fix 64bit alignment issues. This actually reverts a lot of the pattern processing code to something much closer to what it was before any of these checkins: r27670

03/12/10 16:33:28 changed by andy

  • status changed from assigned to closed.
  • resolution set to fixed.

Add/Change #4521 (Use abstract text access APIs in regular expressions)




Anti spam check: