Ticket #4242 (new enhancement)

SVN Diffs for #4242

 

Opened 4 years ago

Last modified 1 year ago

Do All Public Layout Headers Need To Be Public?

Reported by: mader(at)jtcsv.com Assigned to: eric
Priority: minor Milestone: UNSCH
Component: layout Version: cvs
Keywords: layout Cc:
Load: Xref:
Java Version: Operating System: all
Project (C/J): ICU4C Weeks: .5
Review:

Description

Some interesting questions in this message from Terry Luebbe:

Barry,

I need the following header files in order to build my code, so these definitely must be part of your public include set for the ICU layout APIs.

LayoutEngine.h LEFontInstance.h LEGlyphStorage.h LEInsertionList.h LETypes.h LEScripts.h ParagraphLayout.h RunArrays.h

Note, I was a bit surpized that LEInsertionList.h was needed, since its comments describe it as "internal" and its class declaration does not use the "U_LAYOUT_API" define. However, LEGlyphStorage.h includes it, so ICU layout users must have it.

Of the headers that I did not need to build my code..... 1) I am quite sure that "LESwaps.h" is meant to be public. 2) I think "LELanguages.h" is probably meant to be public. 3) I doubt that "LEGlyphFilter.h" is meant to be public.

Eric will have to confirm these speculations.

At the very least, it seems like LEGlypFilter.h shouldn't be public. It might also be a good idea to arrange things so that LEInsertionList.h doesn't need to be public - maybe it can be put in the implementation of LEGlyphStorage.

Attachments

Change History

12/31/69 17:40:54 changed by auditor

  • Tue Sep 27 14:19:34 2005 weiv changed notes2: (via expression '$PglTl3.5') target: "3.4" to "",

10/03/07 10:55:17 changed by eric

  • load changed.
  • xref changed.
  • java changed.
  • revw changed.
  • summary changed from RFE: Do All Public Layout Headers Need To Be Public? to Do All Public Layout Headers Need To Be Public?.

Add/Change #4242 (Do All Public Layout Headers Need To Be Public?)




Anti spam check: